Fix an InvalidOperationException when WeakEventTable.Purge is called …#11521
Open
kmaddock wants to merge 1 commit intodotnet:mainfrom
Open
Fix an InvalidOperationException when WeakEventTable.Purge is called …#11521kmaddock wants to merge 1 commit intodotnet:mainfrom
kmaddock wants to merge 1 commit intodotnet:mainfrom
Conversation
…with EnableWeakEventMemoryImprovements enabled
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…with EnableWeakEventMemoryImprovements enabled
Fixes #6452
Description
If EnableWeakEventMemoryImprovements is true, the WeakEventTable.Purge enumerates through _dataTable calling WeakEventManager.Purge on each list:
WeakEventManager.PurgeInternal redirects to .Purge, which will check the ListenerList for concurrent readers, and clone and update Table (_dataTable) if concurrent readers exist:
Writing to _dataTable invalidates the enumerator in WeakEventTable, which will throw an InvalidOperationException.
This PR exits WeakEventManager.Purge if EnableWeakEventMemoryImprovements is true, the list purge will be retried next time WeakEventTable is purged,
Customer Impact
Our App throws InvalidOperationException and crashes.
Regression
No
Testing
I reprod with the test case attached to issue #6452 and confirmed that this PR fixes it.
Risk
It seems pretty low risk to me
Microsoft Reviewers: Open in CodeFlow